Skip to content

Conversation

@salaboy
Copy link
Contributor

@salaboy salaboy commented Dec 14, 2022

Signed-off-by: salaboy Salaboy@gmail.com

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

This is just a suggestion. Feel free to disregard it, but I used that flag all the time for dev purposes.

Issue reference

@salaboy salaboy requested review from a team as code owners December 14, 2022 08:39
@salaboy
Copy link
Contributor Author

salaboy commented Dec 14, 2022

this is my first PR to the Dapr org, so I might be missing some basic stuff.. please advice.

@yaron2 yaron2 added this to the 1.10 milestone Dec 15, 2022
Copy link
Contributor

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

salaboy and others added 4 commits December 16, 2022 08:30
This is just a suggestion, feel free to disregard it, but I found myself using that flag all the time for dev purposes.

Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: Mauricio Salatino <salaboy@salaboy.local>
Signed-off-by: Lenshood <lenshood.zxh@gmail.com>
Signed-off-by: Mauricio Salatino <salaboy@salaboy.local>
…pubsub.md

Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: salaboy <msalatino@vmware.com>
Signed-off-by: Mauricio Salatino <salaboy@salaboy.local>
…pubsub.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: salaboy <msalatino@vmware.com>
Signed-off-by: Mauricio Salatino <salaboy@salaboy.local>
@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 22, 2022
@github-actions github-actions bot closed this Dec 29, 2022
@yaron2 yaron2 reopened this Dec 29, 2022
@salaboy
Copy link
Contributor Author

salaboy commented Dec 29, 2022

@yaron2 I don't know what is the validate-links issue here.. not sure what to do to unblock this PR

@github-actions github-actions bot removed the stale label Dec 30, 2022
@hhunter-ms hhunter-ms merged commit 57aae50 into dapr:v1.9 Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants