-
Notifications
You must be signed in to change notification settings - Fork 780
Small suggestion to save resources for local dev #3006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is my first PR to the Dapr org, so I might be missing some basic stuff.. please advice. |
hhunter-ms
reviewed
Dec 14, 2022
daprdocs/content/en/getting-started/tutorials/configure-state-pubsub.md
Outdated
Show resolved
Hide resolved
hhunter-ms
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
msfussell
reviewed
Dec 15, 2022
daprdocs/content/en/getting-started/tutorials/configure-state-pubsub.md
Outdated
Show resolved
Hide resolved
This is just a suggestion, feel free to disregard it, but I found myself using that flag all the time for dev purposes. Signed-off-by: salaboy <Salaboy@gmail.com> Signed-off-by: Mauricio Salatino <salaboy@salaboy.local>
Signed-off-by: Lenshood <lenshood.zxh@gmail.com> Signed-off-by: Mauricio Salatino <salaboy@salaboy.local>
…pubsub.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: salaboy <msalatino@vmware.com> Signed-off-by: Mauricio Salatino <salaboy@salaboy.local>
…pubsub.md Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: salaboy <msalatino@vmware.com> Signed-off-by: Mauricio Salatino <salaboy@salaboy.local>
|
Stale PR, paging all reviewers |
|
@yaron2 I don't know what is the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: salaboy Salaboy@gmail.com
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
This is just a suggestion. Feel free to disregard it, but I used that flag all the time for dev purposes.
Issue reference