Skip to content

fix: allow workflow_dispatch for v1.10 SWA deployment#5140

Merged
marcduiker merged 1 commit into
v1.10from
fix/workflow-dispatch-v1-10
Apr 24, 2026
Merged

fix: allow workflow_dispatch for v1.10 SWA deployment#5140
marcduiker merged 1 commit into
v1.10from
fix/workflow-dispatch-v1-10

Conversation

@paulyuk
Copy link
Copy Markdown
Contributor

@paulyuk paulyuk commented Apr 21, 2026

Problem

The build job condition only allows push and pull_request events:

if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.action != 'closed')

workflow_dispatch is excluded, so manual triggers skip the build.

Fix

Use the same condition as website-root.yml:

if: github.event.action != 'closed'

This works for all event types (push, pull_request, workflow_dispatch) and only skips the closed PR action.

Context

Needed after migrating SWAs to the new Azure subscription. When merged, the push event will trigger deployment to the new SWA.

@paulyuk paulyuk requested review from a team as code owners April 21, 2026 23:43
@github-actions
Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-wave-09f2c0f1e-5140.westus2.7.azurestaticapps.net

Signed-off-by: paulyuk <paulyuk@microsoft.com>
@paulyuk paulyuk force-pushed the fix/workflow-dispatch-v1-10 branch from 26e8dfa to 645602d Compare April 22, 2026 06:47
@github-actions
Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-wave-09f2c0f1e-5140.westus2.7.azurestaticapps.net

Copy link
Copy Markdown
Contributor

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcduiker marcduiker merged commit a97273a into v1.10 Apr 24, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants