Skip to content

Conversation

@artur-ciocanu
Copy link
Contributor

@artur-ciocanu artur-ciocanu commented Nov 25, 2025

Description

This is another PR to cleanup the Maven mess that we have. The goal is the same, trying to add some order and ensure it will be easier to upgrade and maintain all the dependencies long term. I also cleaned up the Docker in Docker setup, since we don't need that. It is working just fine with the default Docker that is installed in GitHub Actions Runner.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: N/A

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
@artur-ciocanu artur-ciocanu requested review from a team as code owners November 25, 2025 09:43
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
@artur-ciocanu
Copy link
Contributor Author

@dapr/maintainers-java-sdk could you please review this PR. It has a lot of files, but these are primarily related to moving Maven properties and plugins around for a better organization and ensure proper long term maintenance.

@javier-aliaga could you please also take a look!

Thank you!

siri-varma
siri-varma previously approved these changes Nov 26, 2025
Copy link
Contributor

@siri-varma siri-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
@artur-ciocanu
Copy link
Contributor Author

@dapr/maintainers-java-sdk I have reverted the Testcontainers version now everything should be OK.

@siri-varma and @javier-aliaga if you could take another look that would be great.

Thank you!

Copy link
Contributor

@javier-aliaga javier-aliaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artur-ciocanu artur-ciocanu merged commit fd2606b into dapr:master Nov 28, 2025
10 checks passed
@artur-ciocanu artur-ciocanu deleted the maven-improvements branch November 28, 2025 17:53
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.50%. Comparing base (d759c53) to head (78f2f0d).
⚠️ Report is 239 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1596      +/-   ##
============================================
+ Coverage     76.91%   78.50%   +1.59%     
- Complexity     1592     1934     +342     
============================================
  Files           145      216      +71     
  Lines          4843     5872    +1029     
  Branches        562      659      +97     
============================================
+ Hits           3725     4610     +885     
- Misses          821      924     +103     
- Partials        297      338      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants