-
Notifications
You must be signed in to change notification settings - Fork 224
Create Dapr WaitStrategy to improve ITs ergonomics #1609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
|
@dapr/maintainers-java-sdk @dapr/approvers-java-sdk could you please take a look at this PR. It adds a few primitives to Dapr Testcontainers so it is easier and more reliable to add integration tests using Testconainers. @javier-aliaga please also take a look. Thank you! |
…topic. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
|
@salaboy let me know what you think, I think it is a good addition to Dapr Testcontainers support. |
|
Yes this is amazing .. we need to get this in for 1.17 |
siri-varma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat strategy. LGTM.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1609 +/- ##
============================================
+ Coverage 76.91% 78.75% +1.84%
- Complexity 1592 2035 +443
============================================
Files 145 225 +80
Lines 4843 6115 +1272
Branches 562 669 +107
============================================
+ Hits 3725 4816 +1091
- Misses 821 958 +137
- Partials 297 341 +44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Create Dapr WaitStrategy to improve ITs ergonomics Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Improve unit tests naming and coverage Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix a potential NPE and remove extra "for..." methods for pubsub and topic. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix NPE properly for actor match Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix NPE another potential NPEs. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Rename to use wait strategy to use abstract prefix. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Add more tests to cover null checks Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix pubsub outbox IT. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Ignore pubsub outbox for now. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Disable pubsub outbox for now. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> --------- Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
* Create Dapr WaitStrategy to improve ITs ergonomics Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Improve unit tests naming and coverage Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix a potential NPE and remove extra "for..." methods for pubsub and topic. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix NPE properly for actor match Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix NPE another potential NPEs. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Rename to use wait strategy to use abstract prefix. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Add more tests to cover null checks Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix pubsub outbox IT. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Ignore pubsub outbox for now. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Disable pubsub outbox for now. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> --------- Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
* Create Dapr WaitStrategy to improve ITs ergonomics Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Improve unit tests naming and coverage Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix a potential NPE and remove extra "for..." methods for pubsub and topic. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix NPE properly for actor match Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix NPE another potential NPEs. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Rename to use wait strategy to use abstract prefix. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Add more tests to cover null checks Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix pubsub outbox IT. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Ignore pubsub outbox for now. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Disable pubsub outbox for now. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> --------- Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
* Create Dapr WaitStrategy to improve ITs ergonomics Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Improve unit tests naming and coverage Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix a potential NPE and remove extra "for..." methods for pubsub and topic. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix NPE properly for actor match Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix NPE another potential NPEs. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Rename to use wait strategy to use abstract prefix. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Add more tests to cover null checks Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix pubsub outbox IT. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Ignore pubsub outbox for now. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Disable pubsub outbox for now. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> --------- Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
* Create Dapr WaitStrategy to improve ITs ergonomics Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Improve unit tests naming and coverage Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix a potential NPE and remove extra "for..." methods for pubsub and topic. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix NPE properly for actor match Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix NPE another potential NPEs. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Rename to use wait strategy to use abstract prefix. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Add more tests to cover null checks Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix pubsub outbox IT. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Ignore pubsub outbox for now. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Disable pubsub outbox for now. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> --------- Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Description
Currently we have some very low level way to wait for Dapr container, we are relying on
Wait.forLogMessage(...)it is OK, but it is not Dapr specific and could be brittle. The purpose of this PR is to addDaprWaitthat can wait for Dapr specific components to be up and running.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: