Open
Conversation
Signed-off-by: Javier Aliaga <javier@diagrid.io>
Contributor
Author
|
@olitomlinson can you review? Both method should be deprecated, isnt it? invokeMethod and invokeBinding? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1666 +/- ##
=========================================
Coverage 79.27% 79.27%
Complexity 2151 2151
=========================================
Files 234 234
Lines 6474 6474
Branches 703 703
=========================================
Hits 5132 5132
Misses 989 989
Partials 353 353 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The guidance since 2023 has been to not use SDK invoke* methods for Service Invocation. However this has never been formalised by marking the methods as deprecated.
Instead it is recommended to use language native http clients and grpc clients for Service Invoke.
Factory methods in the SDK which return a native http/grpc client is fine too, and are not deprecated.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1642
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: