fix: adapt to durabletask-protobuf proto file split#1702
Merged
cicoyle merged 1 commit intodapr:masterfrom Mar 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the durabletask client module to build against the refactored dapr/durabletask-protobuf protos after orchestrator_service.proto was split into concept-based proto files.
Changes:
- Switch durabletask proto configuration from a single-file URL to a base URL in the parent
pom.xml. - Download all required durabletask proto files (
orchestrator_service.proto,orchestration.proto,history_events.proto,orchestrator_actions.proto) indurabletask-client/pom.xml. - Update Java references from
OrchestratorService.*message types to the new outer classes (Orchestration,HistoryEvents,OrchestratorActions) across runtime code and tests.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
pom.xml |
Replaces durabletask single-proto URL property with a base URL property for multiple proto downloads. |
durabletask-client/pom.xml |
Adds download-maven-plugin executions to fetch all split proto files needed for codegen/compilation. |
durabletask-client/src/test/java/io/dapr/durabletask/SubOrchestrationCrossAppTest.java |
Updates test references to the new generated proto outer classes and message types. |
durabletask-client/src/main/java/io/dapr/durabletask/runner/OrchestratorRunner.java |
Updates OrchestrationVersion reference to the new Orchestration outer class. |
durabletask-client/src/main/java/io/dapr/durabletask/runner/ActivityRunner.java |
Updates TaskFailureDetails and TraceContext references to Orchestration. |
durabletask-client/src/main/java/io/dapr/durabletask/TaskOrchestratorResult.java |
Updates action type to OrchestratorActions.OrchestratorAction. |
durabletask-client/src/main/java/io/dapr/durabletask/TaskOrchestrationExecutor.java |
Updates history/event/action/router/status types to the new generated outer classes. |
durabletask-client/src/main/java/io/dapr/durabletask/OrchestrationRuntimeStatus.java |
Updates status enum conversions to use Orchestration.OrchestrationStatus. |
durabletask-client/src/main/java/io/dapr/durabletask/OrchestrationMetadata.java |
Switches OrchestrationState type import to Orchestration.OrchestrationState. |
durabletask-client/src/main/java/io/dapr/durabletask/FailureDetails.java |
Switches TaskFailureDetails type import to Orchestration.TaskFailureDetails. |
durabletask-client/src/main/java/io/dapr/durabletask/DurableTaskGrpcWorker.java |
Updates TraceContext reference to Orchestration.TraceContext. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
durabletask-client/src/main/java/io/dapr/durabletask/OrchestrationMetadata.java
Outdated
Show resolved
Hide resolved
durabletask-client/src/main/java/io/dapr/durabletask/TaskOrchestrationExecutor.java
Outdated
Show resolved
Hide resolved
durabletask-client/src/main/java/io/dapr/durabletask/TaskOrchestrationExecutor.java
Outdated
Show resolved
Hide resolved
The dapr/durabletask-protobuf#32 PR refactored protos by concept, splitting orchestrator_service.proto into orchestration.proto, history_events.proto, and orchestrator_actions.proto. This broke the build because only the single file was being downloaded. - Download all 4 proto files in durabletask-client/pom.xml - Replace single-file URL property with base URL in parent pom - Update Java type references from OrchestratorService.* to the correct new outer classes: Orchestration, HistoryEvents, OrchestratorActions Signed-off-by: Javier Aliaga <javier@diagrid.io>
42e687c to
0d29c47
Compare
cicoyle
approved these changes
Mar 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1702 +/- ##
============================================
- Coverage 79.54% 79.53% -0.02%
- Complexity 2196 2197 +1
============================================
Files 238 238
Lines 6591 6591
Branches 732 732
============================================
- Hits 5243 5242 -1
- Misses 990 992 +2
+ Partials 358 357 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The dapr/durabletask-protobuf#32 PR refactored protos by concept, splitting orchestrator_service.proto into orchestration.proto, history_events.proto, and orchestrator_actions.proto. This broke the build because only the single file was being downloaded.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: