-
Notifications
You must be signed in to change notification settings - Fork 228
Support ActorMethod to change method's name. #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e91adf6
Support ActorMethod to change method's name.
artursouza 9aa7a79
Update examples/src/main/java/io/dapr/examples/actors/README.md
artursouza f87502a
Use 'Undefined' as default class for ActorMethod returns.
artursouza 651c778
Update examples/src/main/java/io/dapr/examples/actors/README.md
artursouza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| /* | ||
| * Copyright (c) Microsoft Corporation. | ||
| * Licensed under the MIT License. | ||
| */ | ||
|
|
||
| package io.dapr.actors; | ||
|
|
||
| /** | ||
| * Internal class to represent the undefined value for an optional Class attribute. | ||
| */ | ||
| final class Undefined { | ||
|
|
||
| private Undefined() { | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
sdk-tests/src/test/java/io/dapr/it/actors/ActorMethodNameIT.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| /* | ||
| * Copyright (c) Microsoft Corporation. | ||
| * Licensed under the MIT License. | ||
| */ | ||
|
|
||
| package io.dapr.it.actors; | ||
|
|
||
| import io.dapr.actors.ActorId; | ||
| import io.dapr.actors.client.ActorProxy; | ||
| import io.dapr.actors.client.ActorProxyBuilder; | ||
| import io.dapr.it.BaseIT; | ||
| import io.dapr.it.actors.app.MyActor; | ||
| import io.dapr.it.actors.app.MyActorService; | ||
| import org.junit.Test; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import static io.dapr.it.Retry.callWithRetry; | ||
| import static org.junit.Assert.assertTrue; | ||
|
|
||
| public class ActorMethodNameIT extends BaseIT { | ||
|
|
||
| private static Logger logger = LoggerFactory.getLogger(ActorMethodNameIT.class); | ||
|
|
||
| @Test | ||
| public void actorMethodNameChange() throws Exception { | ||
| // The call below will fail if service cannot start successfully. | ||
| startDaprApp( | ||
| ActorMethodNameIT.class.getSimpleName(), | ||
| MyActorService.SUCCESS_MESSAGE, | ||
| MyActorService.class, | ||
| true, | ||
| 60000); | ||
|
|
||
| logger.debug("Creating proxy builder"); | ||
| ActorProxyBuilder<MyActor> proxyBuilder = deferClose(new ActorProxyBuilder("MyActorTest", MyActor.class)); | ||
| logger.debug("Creating actorId"); | ||
| ActorId actorId1 = new ActorId("1"); | ||
| logger.debug("Building proxy"); | ||
| MyActor proxy = proxyBuilder.build(actorId1); | ||
|
|
||
| callWithRetry(() -> { | ||
| logger.debug("Invoking dotNetMethod from Proxy"); | ||
| boolean response = proxy.dotNetMethod(); | ||
| logger.debug("asserting true response: [" + response + "]"); | ||
| assertTrue(response); | ||
| }, 60000); | ||
|
|
||
| logger.debug("Creating proxy builder 2"); | ||
| ActorProxyBuilder<ActorProxy> proxyBuilder2 = deferClose(new ActorProxyBuilder("MyActorTest", ActorProxy.class)); | ||
| logger.debug("Building proxy 2"); | ||
| ActorProxy proxy2 = proxyBuilder2.build(actorId1); | ||
|
|
||
| callWithRetry(() -> { | ||
| logger.debug("Invoking DotNetMethodAsync from Proxy 2"); | ||
| boolean response = proxy2.invokeMethod("DotNetMethodAsync", boolean.class).block(); | ||
| logger.debug("asserting true response 2: [" + response + "]"); | ||
| assertTrue(response); | ||
| }, 60000); | ||
|
|
||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot refer to the class since it is internal to the package in which it was declared.