Skip to content

Fixes Actor Reminder Incorrect Period#272

Merged
wcs1only merged 2 commits intodapr:masterfrom
berndverst:master
Sep 8, 2021
Merged

Fixes Actor Reminder Incorrect Period#272
wcs1only merged 2 commits intodapr:masterfrom
berndverst:master

Conversation

@berndverst
Copy link
Copy Markdown
Member

@berndverst berndverst commented Sep 8, 2021

Description

  • The serialization of actor reminders incorrectly used the due time value for the period field. This is now fixed.
  • Also bumping the library's protobuf version to be in line with dev requirement.

Issue reference

Fixes #268
Fixes #271

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@berndverst berndverst requested review from a team as code owners September 8, 2021 21:26
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 8, 2021

Codecov Report

Merging #272 (f56d942) into master (04d8389) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #272   +/-   ##
=======================================
  Coverage   89.28%   89.28%           
=======================================
  Files          52       52           
  Lines        2155     2155           
=======================================
  Hits         1924     1924           
  Misses        231      231           
Impacted Files Coverage Δ
dapr/actor/runtime/_reminder_data.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04d8389...f56d942. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Protobuf version ReminderData does not honours period value

2 participants