Added get configuration method for Dapr config API#323
Added get configuration method for Dapr config API#323wcs1only merged 6 commits intodapr:masterfrom amulyavarote:feature/config_get_api
Conversation
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
==========================================
+ Coverage 89.43% 89.48% +0.04%
==========================================
Files 52 52
Lines 2158 2196 +38
==========================================
+ Hits 1930 1965 +35
- Misses 228 231 +3
Continue to review full report at Codecov.
|
|
|
||
| def json(self) -> Dict[str, object]: | ||
| """Gets content as deserialized JSON dictionary.""" | ||
| return json.loads(to_str(self._value)) |
There was a problem hiding this comment.
quick question: is the value a single field or consists multiple items?
There was a problem hiding this comment.
It consists of multiple items.
| raise ValueError("Config store name cannot be empty to get the configuration") | ||
| req = api_v1.GetConfigurationRequest( | ||
| store_name=store_name, keys=keys, metadata=config_metadata) | ||
| response, call = self._stub.GetConfigurationAlpha1.with_call(req) |
There was a problem hiding this comment.
is there a field to pass in custom metadata to the GRPC call similar to other methods ?
There was a problem hiding this comment.
So we talked over this at the release meeting. I think we've made the decision to deprecate the gRPC metadata parameter from all of our APIs given how highly confusing it is to have both dapr and gRPC metadata. I've created a proposal for this: #324
There was a problem hiding this comment.
Based on our meeting, we decided not to add grpc metadata because there is an issue being created to take grpc metadata out completely.
|
|
||
| key = 'greeting' | ||
|
|
||
| # Wait for sidecar to be up within 5 seconds. |
There was a problem hiding this comment.
nitpick: 20 seconds.
Signed-off-by: Amulya Varote <amulyavarote@Ruban-laptop.fareast.corp.microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@Ruban-laptop.fareast.corp.microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@SHRISU-YOGA.redmond.corp.microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@SHRISU-YOGA.redmond.corp.microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@SHRISU-YOGA.redmond.corp.microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@Amulyas-MacBook-Pro.local>
3 participants
Description
Added a method to get the configuration details.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #308
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: