Add timedelta fix#327
Merged
wcs1only merged 8 commits intodapr:masterfrom Jan 13, 2022
Merged
Conversation
Signed-off-by: chinzhiweiblank <chinzhiweiblank@gmail.com>
Signed-off-by: chinzhiweiblank <chinzhiweiblank@gmail.com>
chinzhiweiblank
force-pushed
the
fix/timedelta-precision
branch
from
8d2173f to
614585d
Compare
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
==========================================
+ Coverage 89.58% 89.60% +0.01%
==========================================
Files 52 52
Lines 2219 2222 +3
==========================================
+ Hits 1988 1991 +3
Misses 231 231
Continue to review full report at Codecov.
|
wcs1only
reviewed
Jan 11, 2022
Contributor
wcs1only
left a comment
wcs1only
left a comment
There was a problem hiding this comment.
Thanks so much for your contribution! One minor comment, and we'll get this merged for the next release.
Signed-off-by: chinzhiweiblank <chinzhiweiblank@gmail.com>
chinzhiweiblank
force-pushed
the
fix/timedelta-precision
branch
from
093f16c to
c4b9884
Compare
Signed-off-by: chinzhiweiblank <chinzhiweiblank@gmail.com>
chinzhiweiblank
force-pushed
the
fix/timedelta-precision
branch
from
40b3fde to
4dbd1c3
Compare
wcs1only
approved these changes
Jan 13, 2022
Contributor
wcs1only
left a comment
wcs1only
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your contribution!
berndverst
pushed a commit
to berndverst/python-sdk
that referenced
this pull request
Jan 13, 2022
* Add timedelta fix Signed-off-by: chinzhiweiblank <chinzhiweiblank@gmail.com> Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you've made
Added microseconds and milliseconds to timedelta conversion.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #320
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: