Skip to content

update holopin badge#694

Merged
berndverst merged 3 commits intodapr:mainfrom
andriisoldatenko:update-holopin-badge
Apr 30, 2024
Merged

update holopin badge#694
berndverst merged 3 commits intodapr:mainfrom
andriisoldatenko:update-holopin-badge

Conversation

@andriisoldatenko
Copy link
Contributor

Description

The yaml file to award SDK badges had been updated such that each contributor can be awarded with a SDK badge for their contribution to this repo.

Issue reference

This PR resolves #693

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@andriisoldatenko andriisoldatenko requested review from a team as code owners April 10, 2024 12:23
@andriisoldatenko andriisoldatenko force-pushed the update-holopin-badge branch 2 times, most recently from 2f35769 to 47c3a47 Compare April 10, 2024 12:25
Signed-off-by: Andrii Soldatenko <andrii.soldatenko@gmail.com>
Signed-off-by: Andrii Soldatenko <andrii.soldatenko@dynatrace.com>
Signed-off-by: Andrii Soldatenko <andrii.soldatenko@dynatrace.com>
Copy link
Contributor

@elena-kolevska elena-kolevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, as long as @berndverst is ok with the badge change.

Copy link
Contributor

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andriisoldatenko The alias has some incorrect nested elements (it was incorrect from the start). It just needs the 'sdk-badge' value as per suggestion.

id: clmjkxscc122740fl0mkmb7egi
alias: ghc2023
- id: clrqfdv4x24910fl5n4iwu5oa
alias: { id: clrqfdv4x24910fl5n4iwu5oa, alias: sdk-badge }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
alias: { id: clrqfdv4x24910fl5n4iwu5oa, alias: sdk-badge }
alias: sdk-badge

@berndverst berndverst merged commit 9021b95 into dapr:main Apr 30, 2024
@marcduiker
Copy link
Contributor

@holopin-bot @andriisoldatenko Thanks for your contribution!

@holopin-bot
Copy link

holopin-bot bot commented May 3, 2024

Congratulations @andriisoldatenko, you just earned a badge! Here it is: https://holopin.io/claim/clvqk6tjc267250gjrpyqt2msd

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@yaron2 yaron2 added this to the v1.14 milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the holopin.yaml to use the sdk badge

5 participants