Fix chart refresh race showing stale 'missing' rows after refresh button#120
Merged
Fix chart refresh race showing stale 'missing' rows after refresh button#120
Conversation
The /charts/refresh endpoint queued refresh_chart_task via BackgroundTasks and returned immediately; the UI invalidated after a fixed 5s timeout. The refresh takes ~10s, so the page re-fetched before the DELETE+INSERT transaction had committed and rendered the prior (often wrong-MBID) rows, making them appear as 'missing' in the library until a full page reload. Await the task inline so the HTTP response returns only once chart_album is fully updated, and invalidate the page data immediately on resolve. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /charts/refresh endpoint queued refresh_chart_task via BackgroundTasks and returned immediately; the UI invalidated after a fixed 5s timeout. The refresh takes ~10s, so the page re-fetched before the DELETE+INSERT transaction had committed and rendered the prior (often wrong-MBID) rows, making them appear as 'missing' in the library until a full page reload.
Await the task inline so the HTTP response returns only once chart_album is fully updated, and invalidate the page data immediately on resolve.