Support storing AuthenticateResult in HttpContext/FunctionContext #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artmasa
reviewed
Jul 19, 2024
artmasa
approved these changes
Jul 19, 2024
Contributor
|
@Anpopela-Xbox, thanks for this contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During authentication not all available information is stored in the user identity/the service principal. Normally ASP.NET stores the full authentication result (AuthenticateResult) in a feature via HttpContext.Features. This PR adds support for storing the authenticate result in the HttpContext. This should promote maximum compatibility with other authentication/authorization middleware designed to use these features.
The AuthenticateResult is also stored in the FunctionContext for ease of use.
Tests were added and I believe I emulated the style okish. Please feel free to point out anything I missed!