Skip to content

fix: eliminate race condition in TestBroadcastEvent_Delivery #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darkliquid merged 3 commits into from
Mar 15, 2026
Merged

fix: eliminate race condition in TestBroadcastEvent_Delivery #6

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45df36d
Initial plan
Copilot Mar 15, 2026
ca714bd
fix: resolve race condition in TestBroadcastEvent_Delivery
Copilot Mar 15, 2026
41ac3df
Potential fix for pull request finding
darkliquid Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions internal/ipc/extra_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,24 @@ func TestBroadcastEvent_Delivery(t *testing.T) {
}
defer rawConn.Close()

// Wait until the server has tracked the connection before broadcasting,
// otherwise the event is sent to an empty set of connections.
ticker := time.NewTicker(5 * time.Millisecond)
defer ticker.Stop()
for {
srv.mu.Lock()
tracked := len(srv.conns)
srv.mu.Unlock()
if tracked > 0 {
break
}
select {
case <-ctx.Done():
t.Fatal("timed out waiting for server to track connection")
case <-ticker.C:
}
Comment thread
darkliquid marked this conversation as resolved.
}

// Broadcast an event.
srv.BroadcastEvent(&ipcv1.Event{
Kind: &ipcv1.Event_IndexUpdated{IndexUpdated: &ipcv1.IndexUpdatedEvent{}},
Expand Down
Loading