Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts local developer and GitHub Actions CI/CD configuration to address execution issues by ensuring required directories exist for local integration runs and by forcing GitHub Actions’ JavaScript actions runtime to Node.js 24.
Changes:
- Ensure a local temp directory exists before running Colima-based local integration tests.
- Add
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24env configuration across CI jobs to force Node.js 24 for JavaScript-based actions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
mise.toml |
Creates a temp directory used by local integration tests before invoking go test. |
.github/workflows/ci.yml |
Sets/propagates an env flag intended to force JavaScript actions to run on Node.js 24 for multiple CI jobs. |
Comments suppressed due to low confidence (1)
mise.toml:72
- The temp dir path is duplicated here and again in
TILBO_TEST_TMPDIR=.... To avoid future drift, define the temp dir once (optionally allowing override) and reuse that variable for bothmkdir -pand thego testenv.
mkdir -p $HOME/tmp/tilbo-test
DOCKER_HOST=unix://$HOME/.config/colima/default/docker.sock \
TESTCONTAINERS_DOCKER_SOCKET_OVERRIDE=$HOME/.config/colima/default/docker.sock \
TESTCONTAINERS_RYUK_DISABLED=true \
TILBO_TEST_TMPDIR=$HOME/tmp/tilbo-test \
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| env: | ||
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true |
There was a problem hiding this comment.
The workflow already sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at the top-level env: (applies to all jobs). This job-level env: block is redundant; consider removing it unless this job needs to override the workflow default.
| env: | |
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true |
| env: | ||
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true |
There was a problem hiding this comment.
The workflow already sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at the top-level env: (applies to all jobs). This job-level env: block is redundant; consider removing it unless this job needs to override the workflow default.
| env: | ||
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true |
There was a problem hiding this comment.
The workflow already sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at the top-level env: (applies to all jobs). This job-level env: block is redundant; consider removing it unless this job needs to override the workflow default.
| env: | ||
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true |
There was a problem hiding this comment.
The workflow already sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at the top-level env: (applies to all jobs). This job-level env: block is redundant; consider removing it unless this job needs to override the workflow default.
| env: | ||
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true |
There was a problem hiding this comment.
The workflow already sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at the top-level env: (applies to all jobs). This job-level env: block is redundant; consider removing it unless this job needs to override the workflow default.
| CGO_ENABLED: "0" | ||
| GOOS: linux | ||
| GOARCH: ${{ matrix.goarch }} | ||
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true |
There was a problem hiding this comment.
This job inherits FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 from the workflow-level env: already, so redefining it here is redundant. Consider removing this line to keep the build job env focused on build-specific variables.
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true |
Replace all references to the old separate binaries/directories: - cmd/tilbo-daemon/ → internal/daemon/ (code) or tilbo daemon (command) - cmd/tilbo-quickshell/ → internal/quickshell/ (code) or tilbo gui (command) Covers CLAUDE.md, CONTRIBUTING.md, README.md, docs/architecture.md, proto comments, Go package docs, tasks PRD, CI workflow, and all yggdrasil graph node/drift-state files. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
No description provided.