fix: repair CI#17
Merged
cooper (czxtm) merged 7 commits intomainfrom May 9, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR primarily targets Rust stable clippy compliance in the TUI by refactoring a couple of key-handling/sorting paths, and also introduces a small router-level keybinding behavior change plus a Nix flake CI metadata update.
Changes:
- Refactor init-wizard provider navigation match arms using match guards.
- Adjust env DSL autocomplete scoring sort to satisfy clippy (descending by score via
Reverse). - Route single-key
Helpkeybindings at theApplevel and add a regression test; addherculesCIoutput toflake.nix.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rust/src/tui/views/init_wizard.rs | Collapses guarded up/down navigation logic into match guards. |
| rust/src/tui/views/envs_dsl_editor.rs | Changes autocomplete score sorting to a clippy-friendly descending sort. |
| rust/src/tui/harness.rs | Adds a regression test ensuring ? opens search help instead of being treated as input. |
| rust/src/tui/app.rs | Adds an App-level intercept so KeyAction::Help single-key bindings open the modal help overlay. |
| flake.nix | Adds herculesCI.ciSystems to flake outputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+156
to
+162
| if self | ||
| .keymap | ||
| .action_for_key_in(&key, &[KeyAction::Help]) | ||
| .is_some() | ||
| { | ||
| return self.run_keymap_action(KeyAction::Help); | ||
| } |
Comment on lines
+145
to
+150
| ) | ||
| // { | ||
| herculesCI = { | ||
| ciSystems = [ "x86_64-linux" ]; | ||
| onPush.default.outputs = { | ||
| inherit (self.checks.x86_64-linux) himitsu himitsu-smoke; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification