Conversation
Juanpe Bolívar (arximboldi)
force-pushed
the
jp/more-dogfood
branch
from
2e00a31 to
217c041
Compare
| func writeCanonicalJSON(path string, doc map[string]any, mode string) (bool, error) { | ||
| data, err := json.MarshalIndent(doc, "", " ") | ||
| if err != nil { | ||
| var buf bytes.Buffer |
There was a problem hiding this comment.
omg thank you i was wondering why
There was a problem hiding this comment.
Yeah apparently MarshalIndent does escape all strings!
| mkCheckDerivation = appName: appCfg: cmdName: cmdCfg: let | ||
| appPath = appCfg.path or "."; | ||
| repoRoot = ../../../..; | ||
| repoRoot = self.outPath; |
There was a problem hiding this comment.
interesting - what does this do?
There was a problem hiding this comment.
So ../../../.. is relative to the current codebase, which means, refers to the stackpanel codebase itself. However we want to look into the codebase of the project where we are using stackpanel. self is the derivation that refers to the flake itself (basiocally it is the copy of the flake sources into the /nix/store) and outPath, as per usual in the a derivation, refers the actual path (somewhat equivalent to doing "${self}").
| # Runtime PATH for the generated wrapper script. | ||
| # nodejs is always included so `node` is available when startScript uses it. | ||
| runtimePath = lib.makeBinPath ([pkgs.nodejs] ++ bunCfg.runtimeInputs); | ||
| runtimePath = lib.makeBinPath ([pkgs.nodejs pkgs.bun] ++ bunCfg.runtimeInputs); |
There was a problem hiding this comment.
ah, by any chance is this why it wasnt installing on entry?
There was a problem hiding this comment.
Sadly no. For that simply there is no code doing that in our codebase. You need to enable languages.bun.install from devenv to get that feature.
2 participants
Woof woof.
More small usability issues found along the way of trying the repo in
nixmac.