Fix for issue #18 : Backup not working#93
Merged
Leonavichus merged 1 commit intodarkmoonight:mainfrom Apr 4, 2025
Merged
Conversation
Since android 11+ doesn't allow writing to directories other than Download and Documents, I have written Platform specific code for android to use the SAF. The SAF provides with a uri and also writes the isar backup file to the selected uri. Since we would need bytes to write using the SAF, I first create a file in the Download directory which is allowed on android devices. Then I get the bytes of this file and create the backup file in the directory user selected, and delete the file from the Download folder. On other platforms, I keep the functionality as it was. I didn't have an ios device to test features there, but I have tried to keep the ios functionalities from breaking.
Member
|
Hi! Thank you so much for your contribution! |
Contributor
Author
|
Glad I could help |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since android 11+ doesn't allow writing to directories other than Download and Documents, I have written Platform specific code for android to use the SAF. The SAF provides with a uri and also writes the isar backup file to the selected uri in MainActivity.kt.
Since we would need bytes to write using the SAF, I first create a file in the Download directory which is allowed on android devices. Then I get the bytes of this file and create the backup file in the directory user selected, and delete the file from the Download folder. On other platforms, I keep the functionality as it was.
I didn't have an ios device to test features there, but I have tried to keep the ios functionalities from breaking.