Skip to content

v1.7.0: model rework#171

Merged
darksim33 merged 64 commits intomainfrom
163-rework-models
Jul 23, 2025
Merged

v1.7.0: model rework#171
darksim33 merged 64 commits intomainfrom
163-rework-models

Conversation

@darksim33
Copy link
Owner

@darksim33 darksim33 commented Jul 2, 2025 •
edited
Loading

Adressing #163-rework-models

Features:

  • Changed from model wrappers to classes.
  • Added json editor for less cluttery test parameter file handling
    • Allows to create json files dynmically for different IVIM parameter sets
  • Rework IVIMSegmentedParameters to use 2 subclasses (params_fit1 and params_fit2) instead of one and main class (Rework Segmented Fitting #172)
  • Refactored some attributes

@darksim33 darksim33 linked an issue Jul 2, 2025 that may be closed by this pull request
Rework Models #163
Closed
@darksim33 darksim33 changed the title 163-rework-models v1.7.0: model rework Jul 2, 2025
@darksim33 darksim33 self-assigned this Jul 3, 2025
darksim33 added 27 commits July 7, 2025 16:33
@darksim33
feat: add some tests for ivim models
9caf7f0
@darksim33
feat: add s0 model options
3855b31
@darksim33
feat: add s0 model tests
fe72dbf
@darksim33
docs: update docstrings and file info
876cd52
@darksim33
fix: remove unused import
3813631
@darksim33
feat: rework NNLS classes to match abstract model class
b04bb01
@darksim33
feat: update inits, params and results to match model class
a06d9f4
@darksim33
fix: name string not passed properly
94f5612
@darksim33
feat: add fit_S0 to ivim params
b52db54
@darksim33
feat: add tri exp temp file for t1 without mixing time
8205d0c
@darksim33
feat: add a few tests to ivim params to test weather the class is cre…
44970f5 
…ated properly
@darksim33
feat: rework model property to use private method for ez inheritance
066b0cd
@darksim33
feat: add IVIM segmented exception for compare_attr
a40f671
@darksim33
feat: add IVIM segmented tests for basic class behaviour
bd24c8d
@darksim33
fix: refractor S0
2d54f10
@darksim33
fix: refactor t1
b3ebbff
@darksim33
fix: refactor D
e2ca3a3
@darksim33
feat: rework results getter methods to use fit_model args
6fac519
@darksim33
fix: args and kwargs not passed properly
84b8bf8
@darksim33
fix: fit_t1 is now properly set for params_1 and params_2
c48f5fe
@darksim33
fix: refactor
768ec88
@darksim33
feat: update tests to match new models and result structure
3c0d8c3
@darksim33
feat: instead of the private _fit_module the non-private version as a…
1b227ef 
… class is not accessed directly and the model is called separately
@darksim33
fix: remove fixed todo
760de18
@darksim33
feat: fit_reduced, fit_S0, fit_t1 now properly pass the values to the…
4f81bcf 
… model. Also renamed *reduced* for model to *fit_reduced* for better readability
@darksim33
feat: update NNLSCV model
4434d83
@darksim33
feat: refactor *_comment* to *description*
c731bdb
@darksim33 darksim33 marked this pull request as ready for review July 23, 2025 12:58
@darksim33 darksim33 merged commit 5c60e74 into main Jul 23, 2025
@darksim33 darksim33 deleted the 163-rework-models branch July 23, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@darksim33 darksim33

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rework Models

1 participant

@darksim33