Skip to content

Update cameras.xml with values for Canon EOS 550D#570

Merged
LebedevRI merged 2 commits into
darktable-org:developfrom
yattaro:develop
Nov 28, 2023
Merged

Update cameras.xml with values for Canon EOS 550D#570
LebedevRI merged 2 commits into
darktable-org:developfrom
yattaro:develop

Conversation

@yattaro
Copy link
Copy Markdown
Contributor

@yattaro yattaro commented Nov 28, 2023

The white point value for the Canon EOS 550D/T2i/Kiss X4 when the image is below 200 ISO is missing, resulting in blown highlights. A sample raw image shot on my 550D where this issue can be seen is here.

This PR sets the white point for this camera to 13583 when below 200 ISO.

@yattaro yattaro requested a review from LebedevRI as a code owner November 28, 2023 01:07
@LebedevRI
Copy link
Copy Markdown
Member

As mentioned in darktable-org/darktable#15636 (comment), we really should read these from EXIF.

Could you please take a shot on every ISO level, convert them to DNG and process them with dngmeta.rb to obtain the full set of values?

@yattaro yattaro changed the title Set white point for Canon 550D to 13583 when below 200 ISO Update cameras.xml with values for Canon EOS 550D Nov 28, 2023
@yattaro
Copy link
Copy Markdown
Contributor Author

yattaro commented Nov 28, 2023

As mentioned in darktable-org/darktable#15636 (comment), we really should read these from EXIF.

Could you please take a shot on every ISO level, convert them to DNG and process them with dngmeta.rb to obtain the full set of values?

Got it, here's the resulting output of dngmeta.rb:

invsensors {[2048, 13926]=>[100], [2054, 15000]=>[200, 400, 800, 1600, 3200, 6400, 12800]}

sensors [[100, [2048, 13926]], [200, [2054, 15000]], [400, [2048, 15000]], [800, [2048, 15000]], [1600, [2048, 15000]], [3200, [2048, 15000]], [6400, [2054, 15000]], [12800, [2054, 15000]]]
mostfrequent [[2054, 15000], [200, 400, 800, 1600, 3200, 6400, 12800]]
invsensors {[2048, 13926]=>[100]}

        <Camera make="Canon" model="Canon EOS REBEL T2i">
                <ID make="" model="">Canon EOS 550D</ID>
                <Sensor black="2054" white="15000"/>
                <Sensor black="2048" white="13926" iso_list="100"/>
        </Camera>

I've updated this PR accordingly.

@LebedevRI LebedevRI merged commit 9d27f6e into darktable-org:develop Nov 28, 2023
@LebedevRI
Copy link
Copy Markdown
Member

@yattaro thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants