Update cameras.xml with values for Canon EOS 550D#570
Merged
Conversation
Member
|
As mentioned in darktable-org/darktable#15636 (comment), we really should read these from EXIF. Could you please take a shot on every ISO level, convert them to DNG and process them with dngmeta.rb to obtain the full set of values? |
Contributor
Author
Got it, here's the resulting output of dngmeta.rb: I've updated this PR accordingly. |
Member
|
@yattaro thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The white point value for the Canon EOS 550D/T2i/Kiss X4 when the image is below 200 ISO is missing, resulting in blown highlights. A sample raw image shot on my 550D where this issue can be seen is here.
This PR sets the white point for this camera to 13583 when below 200 ISO.