LJpeg: "ban" point transform#576
Merged
Merged
Conversation
I was looking at the blac/white level reading for CR2, and that apparently requires scaling said levels with the frame precision, and then i have noticed the point transform, and that we apparently never (as of RPU sample set at least) encounter the case where it's actually active. Looking at the spec, the thing that gives me a pause is whether the change to the initial predictor all that is to it, or do we need to also scale the decoded data? Until such case is hit, let's single it out.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #576 +/- ##
===========================================
- Coverage 58.72% 58.72% -0.01%
===========================================
Files 245 245
Lines 14180 14182 +2
Branches 1939 1940 +1
===========================================
+ Hits 8327 8328 +1
- Misses 5735 5736 +1
Partials 118 118
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at the blac/white level reading for CR2, and that apparently requires scaling said levels with the frame precision, and then i have noticed the point transform,
and that we apparently never (as of RPU sample set at least) encounter the case where it's actually active.
Looking at the spec, the thing that gives me a pause is whether the change to the initial predictor all that is to it, or do we need to also scale the decoded data?
Until such case is hit, let's single it out.