Fix a few cases of std::optional mishandling#586
Merged
LebedevRI merged 4 commits intoDec 20, 2023
Conversation
HighPassBand should take reference to optional...
LebedevRI
force-pushed
the
unchecked-optional-access
branch
from
55b03a8 to
f14ef00
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #586 +/- ##
========================================
Coverage 58.40% 58.40%
========================================
Files 247 247
Lines 14481 14481
Branches 1964 1964
========================================
Hits 8457 8457
Misses 5904 5904
Partials 120 120
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hfiguiere
added a commit
to flathub/org.darktable.Darktable
that referenced
this pull request
Jan 17, 2024
Close #112 Signed-off-by: Hubert Figuière <hub@figuiere.net>
hfiguiere
added a commit
to flathub/org.darktable.Darktable
that referenced
this pull request
Jan 17, 2024
Close #112 Signed-off-by: Hubert Figuière <hub@figuiere.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ooops...