oss-fuzz: do build with OpenMP#631
Merged
Merged
Conversation
OpenMP structured blocks can't throw, and that invariant is generally not reflected in the code (unless done manually) when compiled without OpenMP, and that hides bugs (787695f e.g.) `rawspeed_get_number_of_processor_cores()` returns `1` for fuzzers, so there should not be any actual multi-threading done.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #631 +/- ##
========================================
Coverage 60.86% 60.86%
========================================
Files 266 266
Lines 15941 15941
Branches 2053 2053
========================================
Hits 9702 9702
Misses 6108 6108
Partials 131 131
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenMP structured blocks can't throw,
and that invariant is generally not reflected in the code (unless done manually) when compiled without OpenMP, and that hides bugs (787695f e.g.)
rawspeed_get_number_of_processor_cores()returns1for fuzzers, so there should not be any actual multi-threading done.