Skip to content

Leica name normalization (DNG only)#646

Merged
LebedevRI merged 7 commits into
darktable-org:developfrom
kmilos:kmilos/leica_dngs
Feb 6, 2024
Merged

Leica name normalization (DNG only)#646
LebedevRI merged 7 commits into
darktable-org:developfrom
kmilos:kmilos/leica_dngs

Conversation

@kmilos
Copy link
Copy Markdown
Collaborator

@kmilos kmilos commented Feb 6, 2024

AFAICT, these cameras output only DNG, so this is just to normalize the make and model strings.

Leica M (Typ 262)
Leica M-D (Typ 262)
Leica S (Typ 007)
Leica S2
Leica S3
Leica T (Typ 701)
Leica TL
Leica TL2
Leica X1
Leica X Vario (Typ 107)
Leica X (Typ 113)
Leica X-U (Typ 113)

@kmilos kmilos requested a review from LebedevRI as a code owner February 6, 2024 13:11
It is read from the DNG directly, and verified to be the same.
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bec30b6) 60.92% compared to head (3be16ff) 60.92%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #646   +/-   ##
========================================
  Coverage    60.92%   60.92%           
========================================
  Files          266      266           
  Lines        15960    15960           
  Branches      2046     2046           
========================================
  Hits          9723     9723           
  Misses        6105     6105           
  Partials       132      132           
Flag Coverage Δ
benchmarks 10.66% <ø> (ø)
integration 46.11% <ø> (ø)
linux 57.33% <ø> (ø)
macOS 24.28% <ø> (ø)
rpu_u 46.11% <ø> (ø)
unittests 21.63% <ø> (ø)
windows ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LebedevRI
Copy link
Copy Markdown
Member

@kmilos thank you!
I have not verified that these changes are correct, only did a visual inspection of the diff.

@kmilos
Copy link
Copy Markdown
Collaborator Author

kmilos commented Feb 6, 2024

I managed to find quite a few of these DNG samples on either DPReview or PhotographyBlog to test, but not all...

@LebedevRI LebedevRI merged commit d08f3ce into darktable-org:develop Feb 6, 2024
@kmilos kmilos deleted the kmilos/leica_dngs branch February 6, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants