Leica name normalization (DNG only)#646
Merged
Merged
Conversation
It is read from the DNG directly, and verified to be the same.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #646 +/- ##
========================================
Coverage 60.92% 60.92%
========================================
Files 266 266
Lines 15960 15960
Branches 2046 2046
========================================
Hits 9723 9723
Misses 6105 6105
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
@kmilos thank you! |
Collaborator
Author
|
I managed to find quite a few of these DNG samples on either DPReview or PhotographyBlog to test, but not all... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AFAICT, these cameras output only DNG, so this is just to normalize the make and model strings.
Leica M (Typ 262)
Leica M-D (Typ 262)
Leica S (Typ 007)
Leica S2
Leica S3
Leica T (Typ 701)
Leica TL
Leica TL2
Leica X1
Leica X Vario (Typ 107)
Leica X (Typ 113)
Leica X-U (Typ 113)