Open
Conversation
Member
|
So what's the testing story with this, is this hand-made, how do we know the changes are correct?
|
Collaborator
Author
|
Makes sense, will split those. In terms of testing, how about if I check |
Member
|
Hm, thinking about it, let's reorder these then:
... with the last one being the only one i don't know how to validate. Thank you! |
UniqueCameraModel also matches already clean Make and Model
Collaborator
Author
|
This is now only the second step above, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retain/fix ones where UniqueCameraModel differs.