Allow log_shiny_input_changes to have different init level #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I wanted to use
logger::log_shiny_input_changesin a Shiny-app we're building, but was bothered by the fact that the default shiny-inputs are logged at a static INFO-level. It would be nice if that was flexible. The current PR simply takes the level of thelevelargument provided bylog_shiny_input_changesinstead.Is this something you'd be willing to consider?
I added some tests, but they rely on internal structure of the Shiny-package, as the function checks whether the shiny app
isRunning(), and apparently and unfortunately it is not within atestServer.