Change in .spec file to reflect the config file rename#1
Merged
Conversation
…the changes in 8.5
darold
added a commit
that referenced
this pull request
Dec 19, 2012
Change in .spec file to reflect the config file rename
ghost
assigned
Owner
|
I've renamed the sendmailanalyzer.conf.orig extension into sendmailanalyzer.conf.sample as this is what this file it is really. |
Contributor
Author
|
As far as filename extensions are concerned, ".sample" sounds better to me then ",orig", since I use ".orig" for my own purposes. However, are you sure you want to ship an example configuration file in /etc? Wouldn't it be better to ship it in /usr/share/doc/sendmailanalyzer/ and instruct the user to copy it over? |
Owner
|
You are right, I've change install script and .spec to copy sendmailanalyzer.conf.sample into the doc/ directory and copy sendmailanalyzer.conf into etc/ if none already exist. Let me know if there's any issue. Best regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the default config file got renamed from sendmailanalyzer.conf to sendmailanalyzer.conf.orig, the RPM will not build since it cannot find the sendmailanalyzer.conf file.
I've just appended the ".orig" suffix where it's needed, but I'm not sure if there is some more work to be done to bring the .spec up to date with the latest changes.