Fix the .sample file install in doc folder when building an RPM#2
Merged
Conversation
darold
added a commit
that referenced
this pull request
Dec 31, 2012
Fix the .sample file install in doc folder when building an RPM
Owner
|
Applied, thanks a lot Igor ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the RPM does not build. The issue is that it tries to copy the sendmailanalyzer.conf.sample file into /usr/share/doc/sendmailanalyzer-8.6/ folder, but that file does not exist and cannot be copied into the target folder.
This is expected, since the copying is done by install_all.sh script, so the file sendmailanalyzer.conf.sample is never actually created in the origin folder. Since unpackaged files won't terminate the RPM build, i simply let the install_all.sh handle the copying, and I can confirm that the sendmailanalyzer.conf.sample gets created just fine without getting specified in the %doc macro.