fix: allow reviewed force-attach for ingest proposals#13
Merged
Conversation
Add a constrained force-attach path for ingest proposals that are already in needs_review. This lets a bearer-token agent attach a reviewed source to an existing record when the worker could not confidently resolve the match, while keeping the normal worker_proposed approval path unchanged. The new approval path requires force_apply, an explicit existing record_id, sufficient agent confidence, and an evidence-based agent_reason. It refuses force application for normal worker_proposed proposals, create-record writes, missing record targets, low-confidence approvals, and duplicate story URLs. Successful force attachments are audited as approve_force_attach and marked with the ingest_force_attached summary reason. Update the staging approval task to pass FORCE_APPLY=true when needed, and document the operational rules in the ingestion guide, changelog, and remote agent skill. Risk is mostly operator misuse: this is an intentional override for reviewed needs_review attachments, not a shortcut around worker/agent disagreement. The guardrails and tests cover the main failure modes, but future work should add a first-class record_patch proposal flow for canonical metadata updates found during ingest review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a constrained force-attach path for ingest proposals that are already in needs_review. This lets a bearer-token agent attach a reviewed source to an existing record when the worker could not confidently resolve the match, while keeping the normal worker_proposed approval path unchanged.
The new approval path requires force_apply, an explicit existing record_id, sufficient agent confidence, and an evidence-based agent_reason. It refuses force application for normal worker_proposed proposals, create-record writes, missing record targets, low-confidence approvals, and duplicate story URLs. Successful force attachments are audited as approve_force_attach and marked with the ingest_force_attached summary reason.
Update the staging approval task to pass FORCE_APPLY=true when needed, and document the operational rules in the ingestion guide, changelog, and remote agent skill.
Risk is mostly operator misuse: this is an intentional override for reviewed needs_review attachments, not a shortcut around worker/agent disagreement. The guardrails and tests cover the main failure modes, but future work should add a first-class record_patch proposal flow for canonical metadata updates found during ingest review.