This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Add support for library scoping #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Sep 16, 2016
| null, | ||
| _library, | ||
| new LibraryIdentifier([_stringId(name)]), | ||
| null,)); |
Contributor
There was a problem hiding this comment.
Have you run dartfmt on this file?
| final String _name; | ||
| final bool _isField; | ||
| final bool _isOptional; | ||
| final bool _isNamed; |
Contributor
There was a problem hiding this comment.
Is this not the same as _name.isNotEmpty?
Contributor
Author
There was a problem hiding this comment.
Whether it's a named optional parameter. I should probably just make an enum, but it's not like I'm going to be adding more anytime soon.
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
* Add a simple identifier Scope class and a test. * Address comments. * Add some support for scoping (methods, types, parameters) * Add some support to LibraryBuilder and a test. * Pubspec +1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.