This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Add support for is, is! expressions
#111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded a .gitignore rule to exclude the `.idea` directory, for convenience's sake.
kevmoo
reviewed
Jun 15, 2017
.gitignore
Outdated
| pubspec.lock | ||
|
|
||
| # Avoid IntelliJ adding junk files to the repo | ||
| .idea |
Contributor
There was a problem hiding this comment.
Please, don't. These should be ignored in a user's global git ignore.
The number machine and IDE-specific files could grow forever...
Contributor
Author
There was a problem hiding this comment.
Ah, my bad . Didn't realize.
Contributor
Author
|
@kevmoo Fixed |
Contributor
|
@matanlurey should actually help w/ content – my ovly value is making sure |
matanlurey
suggested changes
Jun 15, 2017
lib/src/builders/expression.dart
Outdated
| ExpressionBuilder isInstanceOf(TypeBuilder type) => | ||
| new _IsInstanceOfExpression(this, type); | ||
|
|
||
| @override |
Contributor
There was a problem hiding this comment.
There already is a negate expression, no reason to add this.
lib/src/builders/expression.dart
Outdated
| /// Returns as an [ExpressionBuilder] indicating whether this expression is an instance of [type], using the `is` operator. | ||
| ExpressionBuilder isInstanceOf(TypeBuilder type); | ||
|
|
||
| /// Returns as an [ExpressionBuilder] indicating whether this expression is not an instance of [type], using the `is!` operator. |
| } | ||
| } | ||
|
|
||
| class _IsNotInstanceOfExpression extends AbstractExpressionMixin |
| expect(reference('foo').isInstanceOf(_barType), equalsSource('foo is Bar')); | ||
| }); | ||
|
|
||
| test('should emit an `is!` expression', () { |
Contributor
There was a problem hiding this comment.
OK to keep this test, just use negate instead.
Contributor
Author
There was a problem hiding this comment.
Ok, give me one minute.
Contributor
Author
There was a problem hiding this comment.
Sorry, got preoccupied. Fixed now!
matanlurey
approved these changes
Jun 16, 2017
Contributor
Author
|
Woohoo! 🎉 |
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
* FieldBuilders now works to-level * Ran dartfmt * asThrow on ExpressionBuilder * Removed asThrow * Added isInstanceOf, isNotInstanceOf, and corresponding tests. Also added a .gitignore rule to exclude the `.idea` directory, for convenience's sake. * Undo .gitignore change * Undo .gitignore change, remove IntelliJ metadata * Removed isNotInstanceOf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should take care of dart-lang/tools#925. 😄