Cleanup: Make all ASTs lazy (no _AbstractCodeBuilder) #12
Conversation
|
This also makes the package |
| yet implemented that make it unsuitable for all forms of code | ||
| generation. | ||
|
|
||
| **Contributions are [welcome][welcome]!** |
There was a problem hiding this comment.
Should the second "welcome" be inside round parens: (welcome)?
There was a problem hiding this comment.
[foo][bar] means that [bar] is defined lower in the markdown document, i.e:
[bar]: http://some-long-link-that-is-awkward-inline.com
There was a problem hiding this comment.
Does this mean that there's an error in the [analyzer](analyzer) link above?
lib/src/builders/class_builder.dart
Outdated
|
|
||
| /// Builds a [ClassDeclaration] AST. | ||
| /// | ||
| /// |
There was a problem hiding this comment.
I'm on the edge of my seat in suspense, waiting for docs to appear ;)
lib/src/builders/file_builder.dart
Outdated
| } | ||
| return new ImportBuilder._(astNode); | ||
| } | ||
| const factory ImportBuilder(String uri, {String as}) = ImportBuilder._; |
There was a problem hiding this comment.
as is a Dart keyword. How about withPrefix or just prefix? That's what the language spec calls them I think.
There was a problem hiding this comment.
Done. Changed to prefix
|
Assuming travis passes (does locally) I'll squash and merge. Thanks! |
…ode_builder#12) * Make all builders lazy, remove AST cloning. * Fix breakages due to bad refactor of FileBuilder * Small pubspec increment * Update pubspec to allow pub publish. * Add headers, upstream analyzer patch API * Address comments. * Fix outstanding lints.
3 participants
Closes dart-lang/tools#946