This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Even more expression/code support #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 12, 2017
Merged
alorenzen
approved these changes
Oct 12, 2017
| @override | ||
| visitLiteralListExpression( | ||
| LiteralListExpression expression, [ | ||
| StringSink output, |
Contributor
There was a problem hiding this comment.
Drop the trailing , to be consistent with the rest of the file.
Contributor
Author
There was a problem hiding this comment.
Will address in follow-up PR.
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
* Initial support for Expression(s). * More in changelog. * Add context everywhere. * All tests passing. * More cleanup. * More expression work.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing the gap on the
1.xreleases.Notably, still missing basic things like arguments to invocations, but next PR will add them.