This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Various changes to close a bunch of open issues #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryterkelsen
approved these changes
Nov 15, 2016
| final Set<String> _hide = new Set<String>(); | ||
|
|
||
| factory ImportBuilder(String path, {bool deferred: false, String prefix}) { | ||
| return new ImportBuilder._(path, prefix, deferred); |
Contributor
There was a problem hiding this comment.
it should be an error to have deferred && prefix == null
| export 'package:foo/foo.dart' hide Bar; | ||
| '''), | ||
| ); | ||
| }); |
Contributor
There was a problem hiding this comment.
should error when deferred is true and there is no prefix
Contributor
Author
There was a problem hiding this comment.
I agree. I don't have any checks for any other invalid syntax though, so probably out of scope. Definitely we need sanity checks for obviously invalid syntax.
yjbanov
approved these changes
Nov 15, 2016
| # Make sure we pass the analyzer | ||
| echo "Checking dartanalyzer..." | ||
| FAILS_ANALYZER="$(find lib test -name "*.dart" | xargs dartanalyzer --options analysis_options.yaml)" | ||
| FAILS_ANALYZER="$(find lib test -name "*.dart" | xargs dartanalyzer --options .analysis_options)" |
Contributor
There was a problem hiding this comment.
I'd prefer .yaml because .files are hidden by file managers and ls by default, and this file is just a regular hand-written project file.
Contributor
Author
There was a problem hiding this comment.
Just trying to be consistent with the rest of dart-lang more than anything.
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
…ilder#21) * Various changes. * Update presubmit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.0.0-alpha+1
showandhidesupport toImportBuilderdeferredsupport toImportBuilderExportBuilderlistandmapliterals that support generic typesCloses dart-lang/tools#949
Closes dart-lang/tools#950
Closes dart-lang/tools#951
Closes dart-lang/tools#952
/cc @alorenzen