This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Split FileBuilder into LibraryBuilder and PartBuilder #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/src/file_builder.dart
Outdated
| } | ||
|
|
||
| /// Adds [directive]'s resulting AST to the source. | ||
| void addDirective(CodeBuilder<Directive> directive) { |
Contributor
There was a problem hiding this comment.
This should be in LibraryBuilder and not in PartBuilder, right?
Contributor
Author
|
@yjbanov Yup, whoops! Fixed. |
Contributor
|
LGTM |
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
…ode_builder#3) * Remove unused dependency. * Split FileBuilder into Library/PartBuilder. * Move FileBuilder#addDirectove to LibraryBuilder.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes dart-lang/tools#943