Skip to content
This repository was archived by the owner on Apr 8, 2025. It is now read-only.

Conversation

@Snehal-Singh174
Copy link
Contributor

  • Added support of external keyword for FieldBuilder
  • Issue Add external key word for the FieldBuilder dart-lang/tools#1134
  • Added test case for external keyword inside field_test
  •   expect(
        Field((b) => b
          ..name = 'value'
          ..external = true
          ..type = refer('double')
          ..annotations.addAll([
            refer('Float').call([])
          ])),
        equalsDart(r'''
          @Float()
          external double value;
        '''),
      );
    });
    

@google-cla
Copy link

google-cla bot commented Jun 21, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@natebosch
Copy link
Contributor

I think the addition should be OK. Can you format with dart format to fix the CI error?

We will also need a CHANGELOG entry.

@Snehal-Singh174
Copy link
Contributor Author

Done with the mentioned changes

@natebosch natebosch merged commit aa7f62d into dart-archive:master Jun 22, 2023
mosuem pushed a commit to dart-lang/tools that referenced this pull request Oct 25, 2024
…#422)

Add `external` field to `FieldBuilder` and emit the keyword in the
visitor.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants