Skip to content
This repository was archived by the owner on Apr 8, 2025. It is now read-only.

Close a bunch of open issues for 1.0.0-beta+1 #64

Merged
merged 2 commits into from
Jan 11, 2017
Merged

Close a bunch of open issues for 1.0.0-beta+1 #64

merged 2 commits into from
Jan 11, 2017

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Jan 11, 2017 •
edited
Loading

Closes dart-lang/tools#901
Closes dart-lang/tools#900
Closes dart-lang/tools#898

  • Allow referring to a ClassBuilder and TypeBuilder as an expression
  • Add support for accessing the index [] operator on an expression

BREAKING CHANGES

  • Changed ExpressionBuilder.asAssign to always take an ExpressionBuilder as
    target and removed the value property. Most changes are pretty simple, and
    involve just using reference(...). For example:
literal(true).asAssign(reference('flag'))

... emits flag = true.

@matanlurey matanlurey requested a review from alorenzen January 11, 2017 04:53
@matanlurey matanlurey assigned natebosch and unassigned natebosch Jan 11, 2017
@matanlurey matanlurey requested a review from natebosch January 11, 2017 18:09
@matanlurey matanlurey merged commit 37f08c0 into dart-archive:master Jan 11, 2017
@matanlurey matanlurey deleted the close-more-bugs branch January 11, 2017 18:15
mosuem pushed a commit to dart-lang/tools that referenced this pull request Oct 25, 2024
@matanlurey
Close a bunch of open issues for 1.0.0-beta+1 (dart-archive/code_buil…
2e0eb59 
…der#64)

* Close a bunch of open issues.

* Update CHANGELOG.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alorenzen alorenzen Awaiting requested review from alorenzen

1 more reviewer

@natebosch natebosch natebosch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ReferenceBuilder implements ExpressionBuilder, but TypeBuilder does not Use astFactory for Async and Yield Support to call the indexer [] and []=

3 participants

@matanlurey @natebosch @googlebot