Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

lowerCamelCase check local variables #2579

Merged
pq merged 2 commits into from
Apr 12, 2021
Merged

lowerCamelCase check local variables #2579

pq merged 2 commits into from
Apr 12, 2021

Conversation

@pq
Copy link
Contributor

@pq pq commented Apr 12, 2021

@google-cla google-cla bot added the cla: yes label Apr 12, 2021
@pq
Copy link
Contributor Author

pq commented Apr 12, 2021

FWIW, I'll fix up the dart format churn in another PR.

bwilkerson
bwilkerson reviewed Apr 12, 2021
View reviewed changes
Copy link
Contributor

@bwilkerson bwilkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need some tests for variables declared in for loops (both varieties) and in a catch clause. I suspect that you'll need a couple more visit methods to cover those cases.

@coveralls
Copy link

coveralls commented Apr 12, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.009%) to 94.355% when pulling 785da85 on non_const_var_ids_2 into 12ff9a9 on master.

bwilkerson
bwilkerson reviewed Apr 12, 2021
View reviewed changes
@pq pq merged commit 0c44862 into master Apr 12, 2021
@pq pq deleted the non_const_var_ids_2 branch April 12, 2021 21:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bwilkerson bwilkerson bwilkerson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

update non_constant_identifier_names to include local variables

4 participants

@pq @coveralls @bwilkerson