This repository was archived by the owner on Jan 13, 2025. It is now read-only.
[null-safety] migrate platform to null-safe dart #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
commented
Jul 29, 2020
| @@ -1,12 +1,10 @@ | |||
| name: platform | |||
| version: 2.2.1 | |||
| authors: | |||
There was a problem hiding this comment.
authors field deprecated 🤕
tvolkert
reviewed
Jul 29, 2020
lib/src/testing/fake_platform.dart
Outdated
| this.resolvedExecutable, | ||
| this.script, | ||
| this.executableArguments, | ||
| required this.numberOfProcessors, |
There was a problem hiding this comment.
Making these required is going to be a big breaking change since most uses of FakePlatform are when you know in a test that you only need to fake one field.
Maybe make private fields that are nullable, then the getters that you override for the interface either return the field if it's set, or throw?
There was a problem hiding this comment.
Yeah, that sounds like a good idea.
tvolkert
approved these changes
Jul 29, 2020
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 16, 2024
…rm#24) Migrate platform to null-safety. Remove stable travis shard since that does not support null safety
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate platform to null-safety. Remove stable travis shard since that does not support null safety