Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

Conversation

@dkrutskikh
Copy link
Member

@dkrutskikh dkrutskikh commented Aug 17, 2021

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Tune code climate reporter for support new metrics

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@dkrutskikh dkrutskikh self-assigned this Aug 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #427 (09acba3) into master (2e7ae0a) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #427      +/-   ##
==========================================
+ Coverage   81.36%   81.63%   +0.26%     
==========================================
  Files         176      178       +2     
  Lines        3805     3752      -53     
==========================================
- Hits         3096     3063      -33     
+ Misses        709      689      -20     
Impacted Files Coverage Δ
lib/src/analyzers/lint_analyzer/lint_analyzer.dart 94.83% <ø> (ø)
...analyzer/reporters/models/file_metrics_report.dart 100.00% <ø> (ø)
...zers/lint_analyzer/reporters/utility_selector.dart 60.00% <ø> (-1.37%) ⬇️
lib/src/cli/commands/analyze.dart 46.26% <ø> (ø)
...zers/lint_analyzer/reporters/reporter_factory.dart 100.00% <100.00%> (ø)
..._list/code_climate/lint_code_climate_reporter.dart 97.43% <100.00%> (+12.65%) ⬆️
...s_list/code_climate/models/code_climate_issue.dart 100.00% <100.00%> (ø)
...de_climate/models/code_climate_issue_category.dart 100.00% <100.00%> (ø)
...de_climate/models/code_climate_issue_location.dart 100.00% <100.00%> (ø)
...de_climate/models/code_climate_issue_severity.dart 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e7ae0a...09acba3. Read the comment docs.

@dkrutskikh dkrutskikh changed the title Code climate refactor: update console reporter Aug 17, 2021
@dkrutskikh dkrutskikh requested a review from incendial August 17, 2021 06:26
@dkrutskikh dkrutskikh changed the title refactor: update console reporter refactor: update code climate reporter Aug 17, 2021
@dkrutskikh dkrutskikh added this to the 4.2.0 milestone Aug 18, 2021
const LintAnalyzer();

Reporter? getReporter({
required LintConfig config,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this changes, it's a breaking change and should be managed accordingly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can make it optional though and mark as deprecated.

@dkrutskikh dkrutskikh merged commit bb13514 into master Aug 18, 2021
@dkrutskikh dkrutskikh deleted the code-climate branch August 18, 2021 20:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants