Add Logging support #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // }; | ||
| // } | ||
| /// Extension type for the `logging` capability. | ||
| extension type Logging.fromMap(Map<String, Object?> _value) { |
Contributor
There was a problem hiding this comment.
wdyt of using part files to separate out code in this file by its functionality? logging, prompts, tools, etc. Might be a nice way to group types / logic that go together.
Contributor
Author
There was a problem hiding this comment.
Sure yeah that makes sense - ok if I do that in a follow-up?
Contributor
There was a problem hiding this comment.
Yep follow up refactor sgtm
kenzieschmoll
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://spec.modelcontextprotocol.io/specification/2025-03-26/server/utilities/logging/
I also fixed a bug in the resource support - I realized that subscribe/unsubscribe are supposed to return an empty response instead of no response.
Also updated a few of the extension types to take a
MetaWithProgressToken.