add testing on windows #49
Conversation
only run travis when PR updates, or when merging to master
|
I don't feel qualified to vet the specifics of how this works since I don't know anything about |
There was a problem hiding this comment.
Why only test master? I actually found it handy to have Travis test all branches, since that let us do experimental work on a branch and see the results immediately, without having to do pull requests to trigger testing.
There was a problem hiding this comment.
This is a misleading line. It's not what you think it means. :)
Traditionally, Travis will kick off two builds when you push a PR, or update a PR: one build for the branch and one build for the PR. This is duplicate work.
This config line here implicitly says "run a test when you push a PR, and when master changes"
There was a problem hiding this comment.
Um, actually, that's exactly what I thought it meant. I realize that for the workflow of "push a branch, then immediately make a pull request" it's duplicate work. But that's not the only workflow. Another useful workflow is "push a branch, then look at the travis status to determine whether additional work is needed before making a push request." I think this workflow is useful too, and if the duplicate work in the former case isn't costing too much, I think it's worth putting up with it in order to allow the latter case.
How much is the duplicate work costing us, anyhow?
There was a problem hiding this comment.
It's free. :)
Feel free to change it, no worries!
|
Lgtm If appveyor is still unhappy after this lands I can help diagnose in the PM. |
|
Thanks. I'll watch the builds. |
No description provided.