better support rebuilds after package graph updates #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
approved these changes
Nov 4, 2016
Member
natebosch
left a comment
natebosch
left a comment
There was a problem hiding this comment.
Can you include details on what the problem was and how this solves it in the commit message? Also mention the changes in the e2e_example and how they relate
e2e_example/tool/watch.dart
Outdated
| /// the transitive deps issue. | ||
| CopyBuilder.addPhases(phases, graph); | ||
|
|
||
| /// Adds all the phases necessary to copy all files into a fake packages dir! |
Member
There was a problem hiding this comment.
might want to fix existing cases in this file - these aren't doc comments and shouldn't use triple slash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #135