-
Notifications
You must be signed in to change notification settings - Fork 220
Log requests and request failures in build daemon asset server #3144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@natebosch @grouma @jakemac53 I am thinking about cancelling this PR, as I actually only need one change in it (logging the exception that happens in the asset server handler). I realized that I can log requests from webdev as well, without adding flags to the build daemon, and the rest of the changes are just to enable more logging to debug the failures I encountered in this PR. Anyway, it helped me narrow down the actual issue and find the solution for it so there was a benefit:) I'll submit a new one just for logging exceptions. Update: would be still good to keep the tests. I will remove all the parts I don't need and keep http config change, tests, and logging exception in asset server handler. Update: I decided to just modify this PR instead of cancelling. I kept the --log-requests flag to the daemon as well as the changes mentioned above, it can be useful for debugging the requests to the server. |
54ac558 to
ea520e5
Compare
|
@natebosch @jakemac53 @grouma I addressed (i think) all comments. Changes I kept - let me know if you would like me to remove any of them:
|
Co-authored-by: Nate Bosch <nbosch1@gmail.com>
--log-requestsflag to build runner daemon command.to prevent CI from failing with reset connection errors.
Extra logging will help diagnose CI flakes in build:
https://github.com/dart-lang/build/runs/3062926301
and webdev:
Related: dart-lang/webdev#1345