Fix intermittent broken sockets on connection to asset server. #1353
Conversation
grouma
left a comment
grouma
left a comment
There was a problem hiding this comment.
Can you explain how this addresses the issue?
I run some experiments (see newly added tests) and was able to repro a bunch of broken sockets if I tried to read a few hundred files simultaneously on my local machine. I suppose the machine just runs out of sockets at some point (or we hit some bug the http library). Restricting number of connections on the client to 200 means that all the extra connections will get buffered and eventually connected when the number of active connections drops below the limit. Removing the |
annagrin
force-pushed
the
annagrin/fix_socket_errors
branch
from
10c4f25 to
dae80db
Compare
annagrin
force-pushed
the
annagrin/fix_socket_errors
branch
from
dae80db to
2c05036
Compare
- remove tests waiting for COMPILER_UPDATE_DEPENDENCIES event since there is no way to start listening to debugger events before it is emitted, so the test was faiing randomly. - change expression evaluation tests to expect their events eventually, skipping potential COMPILER_UPDATE_DEPENDENCIES event that sometimes would get be picked up by the listener if it happened later that the listener setup.
2 participants
Limit number of simultaneous connections to prevent SocketExceptions.
Restricting number of connections on the client to 200 causes all the extra connections
to buffer, and eventually connect when the number of active connections drops below
the limit. This prevents SocketExceptions that cause flakes in the CI.
Removing the
maxConnectionsPerHoston the client in new tests will repro the issue.Hopefully fixes flaky behavior in DDR as well (pending performance measurements).
Closes: #1345