Skip to content

Add random benchmark shape. #4280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2025
Merged

Add random benchmark shape. #4280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0874a34
Add random benchmark shape.
davidmorgan Nov 13, 2025
c244ae3
Address review comments.
davidmorgan Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion _benchmark/lib/shape.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

import 'dart:math';

import 'benchmark.dart';

/// The shape of the dependency graph.
Expand All @@ -26,7 +28,10 @@ enum Shape {
///
/// Considered in alphanumeric order, each one has a dependency on the one
/// before. The first library depends on `app.dart`.
backwards;
backwards,

/// Randomly connected libraries.
random;

Iterable<String> importNames(
int libraryNumber, {
Expand Down Expand Up @@ -59,6 +64,21 @@ enum Shape {
benchmarkSize: benchmarkSize,
),
];
case Shape.random:
// Use random.nextInt(random.nextInt(...)) to get a distribution of
// imports biased towards lower number libraries, which is more
// realistic than flat random imports.
final numberOfImports = _random.nextInt(_random.nextInt(10) + 1);
return [
if (_random.nextInt(libraryNumber + 1) == 0) 'app.dart',
for (var i = 0; i != numberOfImports; ++i)
Benchmarks.libraryName(
_random.nextInt(_random.nextInt(benchmarkSize) + 1),
benchmarkSize: benchmarkSize,
),
];
}
}
}

final _random = Random(0);