Add random benchmark shape. #4280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
davidmorgan
force-pushed
the
benchmark-tree
branch
from
ca66e35 to
0874a34
Compare
jensjoha
approved these changes
Nov 14, 2025
_benchmark/lib/shape.dart
Outdated
| if (_random.nextInt(libraryNumber + 1) == 0) 'app.dart', | ||
| for (var i = 0; i != numberOfImports; ++i) | ||
| Benchmarks.libraryName( | ||
| _random.nextInt(_random.nextInt(benchmarkSize + 1) + 1) + 1, |
There was a problem hiding this comment.
At least give a comment about all the +1s...
As I read it, if benchmarkSize is 9 this will give a number between 1 and 10 which Benchmarks.libraryName will then stringify to "between" lib2.dart and lib11.dart which might be right, but at least doesn't seem right (to me).
Contributor
Author
There was a problem hiding this comment.
Whoops, yes, it was too many +1s.
Only need one +1 to avoid passing 0 to nextInt; and libraryName does +1 as you pointed out.
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older build_runner versions stack overflow on very large max import "depth", so the other benchmark "shapes" don't work.
It would anyway be more realistic to have much more mixed imports.
So, add a "shape" with random imports. Use low-number-biased random numbers instead of flat random numbers as random flat imports are not realistic, either.