Optimize library cycle loader. #4281
Merged
+11
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
davidmorgan
force-pushed
the
optimize-library-cycles
branch
from
45100ad to
cba613f
Compare
|
The yellow line in the chart was so low I only noticed it when I read the legend 😂 👏🏻👏🏻👏🏻 |
jensjoha
approved these changes
Nov 14, 2025
| /// | ||
| /// A [_graphs] entry will be created for each ID in [newCycles]. | ||
| void _buildGraphs(int phase, {required List<LibraryCycle> newCycles}) { | ||
| // Build lookup from ID to [LibraryCycle] including new and existing cycles. |
There was a problem hiding this comment.
Am I reading this right, that this boils down to not pre-populating the map?
Contributor
Author
There was a problem hiding this comment.
Yes, exactly :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmark in #4280 shows another quadratic scaling problem: in the number of library cycles.
The code is currently doing work for every already-loaded library cycle for every library cycle.
A simple change only does the work for deps that are actually needed.
Edit+incremental build on "random" benchmark before this PR, aot
Edit+incremental build on "random" benchmark after this PR, aot