#2979. Update existing and add new tests checking nnbd static errors #2984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Nov 20, 2024
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good, couple of comments!
sgrekhov
commented
Nov 20, 2024
Contributor
Author
sgrekhov
left a comment
sgrekhov
left a comment
There was a problem hiding this comment.
Descriptions updated. PTAL
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Nov 27, 2024
2024-11-25 sgrekhov22@gmail.com Fixes dart-lang/co19#2994. Fix a typo in type_void_A06_t11.dart (dart-lang/co19#2995) 2024-11-25 sgrekhov22@gmail.com dart-lang/co19#2559. Fix wrong assertion text in augmenting_constructors_A18_*.dart (dart-lang/co19#2993) 2024-11-25 sgrekhov22@gmail.com dart-lang/co19#2976. Add grammar tests (dart-lang/co19#2990) 2024-11-25 sgrekhov22@gmail.com Fixes dart-lang/co19#2991. Fix typos and separate tests with `external` (dart-lang/co19#2992) 2024-11-25 sgrekhov22@gmail.com dart-lang/co19#2559. Update assertions for some Augmenting libraries tests (dart-lang/co19#2989) 2024-11-21 sgrekhov22@gmail.com dart-lang/co19#2119. Update assertion texts in Wildcards tests (dart-lang/co19#2981) 2024-11-20 sgrekhov22@gmail.com dart-lang/co19#2956. Add more type `void` and `dynamic` tests (dart-lang/co19#2987) 2024-11-20 sgrekhov22@gmail.com dart-lang/co19#2979. Update existing and add new tests checking nnbd static errors (dart-lang/co19#2984) 2024-11-20 sgrekhov22@gmail.com dart-lang/co19#2979. Fix CFE failures in nnbd weak-mode tests (dart-lang/co19#2988) 2024-11-19 sgrekhov22@gmail.com dart-lang/co19#2956. Update and rename existing tests for type `void` (dart-lang/co19#2978) 2024-11-19 sgrekhov22@gmail.com dart-lang/co19#2559. Update assertions in some Augmenting libraries tests (dart-lang/co19#2986) 2024-11-19 sgrekhov22@gmail.com Fixes dart-lang/co19#2983. Change expected error in generic_parameter_inference_A01_t05.dart (dart-lang/co19#2985) 2024-11-18 sgrekhov22@gmail.com dart-lang/co19#2979. Update NNBD static errors tests. Part 2 (dart-lang/co19#2982) 2024-11-15 sgrekhov22@gmail.com dart-lang/co19#2979. Update NNBD static errors tests (dart-lang/co19#2980) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: Ib1dcad2edfa7c6fdd996c6db94173bec91e68368 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397340 Commit-Queue: Alexander Thomas <athom@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.