-
Notifications
You must be signed in to change notification settings - Fork 29
#2979. Update existing and add new tests checking nnbd static errors #2984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file | ||
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| /// @assertion It is an error to derive a mixin from a class declaration which | ||
| /// contains an instance variable with a potentially non-nullable type and no | ||
| /// initializer expression unless the variable is marked with the `late` | ||
| /// modifier. | ||
| /// | ||
| /// @description Check that it is an error for a mixin class to contain an | ||
| /// instance variable with a potentially non-nullable type and no initializer | ||
| /// expression. | ||
| /// @author sgrekhov22@gmail.com | ||
|
|
||
| mixin class C { | ||
| Object instance; | ||
| // ^^^^^^^^ | ||
| // [analyzer] unspecified | ||
| // [cfe] unspecified | ||
| } | ||
|
|
||
| main() { | ||
| print(C); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file | ||
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| /// @assertion It is an error to derive a mixin from a class declaration which | ||
| /// contains an instance variable with a potentially non-nullable type and no | ||
| /// initializer expression unless the variable is marked with the `late` | ||
| /// modifier. | ||
| /// | ||
| /// @description Check that it is not an error for a mixin class to contain an | ||
| /// instance variable with a potentially non-nullable type and no initializer | ||
| /// expression but this variable is marked `late`. | ||
| /// @author sgrekhov22@gmail.com | ||
|
|
||
| mixin class C { | ||
| late Object instance; | ||
| } | ||
|
|
||
| main() { | ||
| print(C); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file | ||
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| /// @assertion It is not an error for the body of a `late` field to reference | ||
| /// `this`. | ||
| /// | ||
| /// @description Check that it is not an error for the body of a `late` field to | ||
| /// reference `this`. | ||
| /// @author sgrekhov22@gmail.com | ||
|
|
||
| // Requirements=nnbd-strong | ||
|
|
||
| import "../../Utils/expect.dart"; | ||
|
|
||
| class A { | ||
| int one = 1; | ||
| } | ||
|
|
||
| class C extends A { | ||
| int two = 2; | ||
| late Function p1 = () => this.one; | ||
| late final p2 = () { | ||
| return this.two; | ||
| }; | ||
| } | ||
|
|
||
| main() { | ||
| Expect.equals(1, new C().p1()); | ||
| Expect.equals(2, new C().p2()); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file | ||
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| /// @assertion If the static type of `e` is `void`, the expression `await e` is | ||
| /// a compile-time error. | ||
| /// | ||
| /// @description Check that it is a compile-time error if in a `await e` | ||
| /// expression the static type of `e` is `void`. | ||
| /// @author sgrekhov22@gmail.com | ||
|
|
||
| void foo() {} | ||
|
|
||
| main() async { | ||
| void e = 0; | ||
| await e; | ||
| // ^ | ||
| // [analyzer] unspecified | ||
| // [cfe] unspecified | ||
| await foo(); | ||
| // ^^^ | ||
| // [analyzer] unspecified | ||
| // [cfe] unspecified | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file | ||
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| /// @assertion Let `C` be a type literal denoting a class, mixin, or extension. | ||
| /// It is a warning to use a null aware member access with receiver `C`. | ||
| /// | ||
| /// @description Check that it is a warning to use a null aware member access | ||
| /// with a type literal. | ||
| /// @author sgrekhov22@gmail.com | ||
|
|
||
| class C { | ||
| static void test() {} | ||
| } | ||
|
|
||
| mixin M { | ||
| static void test() {} | ||
| } | ||
|
|
||
| enum E { | ||
| e0; | ||
| static void test() {} | ||
| } | ||
|
|
||
| class A {} | ||
|
|
||
| extension Ext on A { | ||
| static void test() {} | ||
| } | ||
|
|
||
| extension type ET(int _) { | ||
| static void test() {} | ||
| } | ||
|
|
||
| main() { | ||
| C?.test(); | ||
| // ^^ | ||
| // [analyzer] unspecified | ||
| M?.test(); | ||
| // ^^ | ||
| // [analyzer] unspecified | ||
| E?.test(); | ||
| // ^^ | ||
| // [analyzer] unspecified | ||
| Ext?.test(); | ||
| // ^^ | ||
| // [analyzer] unspecified | ||
| ET?.test(); | ||
| // ^^ | ||
| // [analyzer] unspecified | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file | ||
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| /// @assertion It is no longer a warning to override a method which has a | ||
| /// default value for a parameter with a method with a different default value | ||
| /// for the corresponding parameter. | ||
| /// | ||
| /// @description Check that it is not a warning to override a method which has a | ||
| /// default value for a parameter with a method with a different default value | ||
| /// for the corresponding parameter. | ||
| /// @author sgrekhov22@gmail.com | ||
|
|
||
| import '../../Utils/expect.dart'; | ||
|
|
||
| class A { | ||
| int foo([int x = 1]) => x; | ||
| int bar({int x = 1}) => x; | ||
| } | ||
|
|
||
| class C extends A { | ||
| int foo([int x = 2]) => x; | ||
| int bar({int x = 2}) => x; | ||
| } | ||
|
|
||
| main() { | ||
| Expect.equals(2, C().foo()); | ||
| Expect.equals(2, C().bar()); | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.